Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Refactoring work: defining SSH params to reuse #872

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Refactoring work: defining SSH params to reuse #872

merged 1 commit into from
Jan 23, 2017

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Jan 23, 2017 •
edited
Loading

Refactoring work: defining SSH params to reuse (addressing Ritesh's comment)

Testing Done: Yes (ran locally)

=== RUN   TestVolumeCreationFirstTime

creating volume [abc_1485154865] on VM[10.20.105.89]
destroying volume [abc_1485154865]--- PASS: TestVolumeCreationFirstTime (8.15s)
	createVolume_test.go:60: 
		Testcase passed: successfully able to create volume [abc_1485154865
		]
PASS

@shuklanirdesh82 shuklanirdesh82 self-assigned this Jan 23, 2017
@shuklanirdesh82 shuklanirdesh82 mentioned this pull request Jan 23, 2017
Merged
@shuklanirdesh82 shuklanirdesh82 merged commit 5ec29bb into vmware-archive:master Jan 23, 2017
@shuklanirdesh82
Copy link
Contributor Author

Thanks @kerneltime for the quick review!

@shuklanirdesh82 shuklanirdesh82 deleted the trivialTestFix.shuklanirdesh82 branch January 23, 2017 15:01
shaominchen pushed a commit that referenced this pull request Jan 25, 2017
@shuklanirdesh82
Refactoring work: defining SSH params to reuse (addressing Ritesh's c…
3753efc 
…omment) (#872)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees

@shuklanirdesh82 shuklanirdesh82

Labels
cla-not-required component/test-infrastructure kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuklanirdesh82 @kerneltime @vmwclabot