This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Reduce CI run time. Add gofmt updates. #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deploy-and-test-wrapper.sh: changes looks good to me.
Thanks for fixing! This one is already addressed as part of my previous checkin. |
shuklanirdesh82
approved these changes
Jan 23, 2017
msterin
approved these changes
Jan 23, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces CI time down by close to half.
We currently run the same target test-esx 2 times against each ESX since we blindly repeat the entire test suite against each target. This change will only run test-esx once per ESX.
Also, picked up some gofmt complaints.