Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Handle case correction for Windows plugin #2022

Merged
merged 2 commits into from
Dec 11, 2017

Conversation

govint
Copy link
Contributor

@govint govint commented Dec 5, 2017

Modified plugin_utils:GetVolumeInfo() to handle case sensitivity for windows platform. This is not tested yet for the windows platform yet.

Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me!

Please repush to trigger CI for the last commit.

@govint
Copy link
Contributor Author

govint commented Dec 10, 2017

Thanks to @shuklanirdesh82 and @ashahi1 for the Windows VM set up, verified the fix on Windows:

  1. Create a volume cvol1

  2. Run two containers with cvol1 and cvol1@vsanDatastore

  3. Check the volume names used for the two containers,
    PS C:\Users\root> docker ps
    CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
    5d03844ef3fd microsoft/nanoserver "powershell" 11 minutes ago Up 11 minutes condescending_colden
    7dd53858f664 microsoft/nanoserver "powershell" 15 minutes ago Up 14 minutes loving_torvalds

     "Mounts": [
         {
             "Type": "volume",
             "Name": "cvol1@vsandatastore", <------------
             "Source": "C:\\Windows\\system32\\config\\systemprofile\\AppData\\Local\\docker-volume-vsphere\\mounts\\cvol1@vs
    

anDatastore\",
"Destination": "c:\vol",
"Driver": "vsphere",
"Mode": "",
"RW": true,
"Propagation": ""
}
],

And the second container,

    "Mounts": [
        {
            "Type": "volume",
            "Name": "cvol1", <----------------
            "Source": "C:\\Windows\\system32\\config\\systemprofile\\AppData\\Local\\docker-volume-vsphere\\mounts\\cvol1@vs

anDatastore\",
"Destination": "c:\vol",
"Driver": "vsphere",
"Mode": "",
"RW": true,
"Propagation": ""
}
],

@govint
Copy link
Contributor Author

govint commented Dec 10, 2017

@shuklanirdesh82, do I merge the change, for some reason CI isn't showing up for this PR.

@shuklanirdesh82
Copy link
Contributor

#2022 (comment)

Yeah sure!

@shuklanirdesh82 shuklanirdesh82 merged commit ee64c1a into vmware-archive:master Dec 11, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants