Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Voila looks in the wrong location for an extension via CDN #1128

Closed
timkpaine opened this issue Mar 27, 2022 · 4 comments
Closed

Voila looks in the wrong location for an extension via CDN #1128

timkpaine opened this issue Mar 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@timkpaine
Copy link
Member

Description

Packages pushed to CDN may define widget/extension entrypoints other than index.js.

xref: finos/perspective#1773
voila extension loader:

voila/packages/voila/src/loader.ts

Line 44 in 857eb69

return `${cdn}${packageName}@${moduleVersion}/dist/${fileName}`;

Expectation

We should inspect the main attribute of the package.json if possible to identify the entrypoint.

Context

voila version: all to date
@timkpaine timkpaine added the bug Something isn't working label Mar 27, 2022
This was referenced May 8, 2022
Closed
Merged
@timkpaine
Copy link
Member Author

No dist/index.js: #882

@timkpaine
Copy link
Member Author

#894

@timkpaine
Copy link
Member Author

#892

@timkpaine timkpaine mentioned this issue Jul 5, 2023
Closed
@trungleduc
Copy link
Member

Loading extensions from CDN is removed in 0.5.0

@timkpaine timkpaine mentioned this issue Apr 5, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default to the base package to let the CDN handle browser/main resolution
2 participants
@timkpaine @trungleduc