Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Using typescript-generator without GPL 1 #628

Closed
Herr-Sepp opened this issue Feb 1, 2021 · 4 comments
Closed

Using typescript-generator without GPL 1 #628

Herr-Sepp opened this issue Feb 1, 2021 · 4 comments

Comments

@Herr-Sepp
Copy link

Hi, is it possible to use the typescript-generator without its dependency to com.sun.xml.bind:jaxb-impl:jar:2.3.1 ?

Because it brings the GPL 1.1 license with it.
I dont need support for the old JAXB, is there a way to build / use Typescript-generator without it? Or only using com.sun.xml.bind:jaxb-impl:jar:3.0.0 what also dont have the GPL license anymore.

Sorry if this is a stupid question. I have no experience in the area and thanks for your great software.

@vojtechhabarta
Copy link
Owner

Hi, it is not possible to build typescript-generator without JAXB. At least dependency on JAXB annotations should be present (moreover it is in some Jackson and Jersey dependencies transitively).

JAXB is also used internally in typescript-generator to load Javadoc comments from XML files. I checked if it would be possible to upgrade JAXB dependency to 3.0.0 but there is no update for JAXB plugin highsource/jaxb-tools#199 yet.

But main problem with JAXB 3 is that annotations were moved from javax.xml.bind.annotation package to jakarta.xml.bind.annotation so even if there is updated JAXB plugin it will still be needed to have dependency to JAXB 2 annotations to support present user code.

However I realized that there is newer version of JAXB (2.3.2) which has different license than 2.3.1. So I updated JAXB version and changed javax.xml.bind:jaxb-api dependency to jakarta.xml.bind:jakarta.xml.bind-api, see #629. Maybe this could solve your issue, what do you think?

@Herr-Sepp
Copy link
Author

Yes thank you very much, that solved my problem.
I never expected such a quick solution.

Thanks a million

@vojtechhabarta
Copy link
Owner

PR: #629, released in 2.29.814.

@vojtechhabarta
Copy link
Owner

@Herr-Sepp just a heads up: in order to support both JAXB 2 and JAXB 3 in v2.34.976 it was needed to change dependencies (8b7ef48). Hopefully it is acceptable for you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants