Retrieval of select deleted records

[lyuboxa]

Hello,

I have a use case where I need to retrieve all deleted records or some records which have been deleted past certain day. E.q.

SELECT * FROM pilots WHERE deleted_at IS NULL OR deleted_at > ::timestamp

With models I'd write something like this:

models.Pilots(
  qm.WithDeleted(),
  qm.Expr(
      qm.Or2(models.PilotsWhere.DeletedAt.GTE(..),
      models.PilotesWhere.DeletedAt.IsNull()
   ),
)

Considering my models are generated with soft-deletes enabled, the deleted_at IS NULL mod is appended at the end of stack. Before the final bind.

I think there is an issue with how WithDeleted works via removeSoftDeleteWhere by removing the first instance of deleted_at which breaks the OR in my example. Not sure if this is intended and if there is another way to write this?

Thanks
Lyubo

[aarondl]

Oh that is a bit awkward and I hadn't thought of this case when I coded it that way. The whole deleted_at inclusion/exclusion thing is a bit frustrating and bolt-on.

Definitely seems like it's going to find that and remove it "for you" haha. It may actually make more sense to delete from the end instead of the start given that most of the time it will be appended on to at the end of the query mods you've added.

[aarondl]

This is fixed and will be available in a release sometime.

[lyuboxa]

Thank you @aarondl. I could have attempted a fix, but wasn't sure of the other use cases you had in mind.