Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Native controls don't seem to be themed properly #40

Open
Nantris opened this issue Dec 4, 2024 · 3 comments
Open

Native controls don't seem to be themed properly #40

Nantris opened this issue Dec 4, 2024 · 3 comments

Comments

@Nantris
Copy link

Nantris commented Dec 4, 2024

Native controls meaning: Alert, datetime picker, select, etc.


You can see the repro here:

Nantris/theme-control-demo

setThemePreference('dark') is called here: Nantris/theme-control-demo@master/App.js#L5


To build the project you can run:

eas build --profile=preview -p=android --local for the production-like APK or eas build --profile=devclient -p=android --local to build the dev-client for testing.

I installed the built app to my wireless-debugging connected device using adb install -r ./build-[datetime].apk


To demonstrate the issue:

Run the app (named theme-control-demo) and press the button to create an alert. The code dictates that the theme should be dark, but it's always light.

@Nantris
Copy link
Author

Nantris commented Jan 6, 2025

@vonovak - Happy New Year! I wonder if you've had any new thoughts on what might cause this?

Thanks again for your great work!

@Nantris
Copy link
Author

Nantris commented Feb 13, 2025

Friendly bump. If this worked it would be such a wonderful addition to the ecosystem.

Either way, thank you for all that you've already contributed!

@vonovak
Copy link
Owner

vonovak commented Feb 13, 2025

Hello,
Apologies, I'll look into this, but might take a while, as I have other priorities,

If you contribute a PR with a fix, I'll be happy to merge it!

V.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants