Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move AbstractTransport/TransportInterface from thruway/client to voryx/thruway-common #359

Open
boenrobot opened this issue Dec 22, 2021 · 0 comments

Comments

@boenrobot
Copy link

boenrobot commented Dec 22, 2021

I wasn't sure if this is the right place, as this is a cross repo organization issue, but seeing this repo is the final destination, it's probably the right place...

If one tries to open a thruway router transport like thruway/ratchet-transport as a standalone project, and install it, they don't have all the dependencies required to get the full picture. Specifically, the abstract transport is not present. The project thruway/client needs to be added to that composer.json's require-dev to address this. However, that doesn't sound right to me for a router transport.

So I think the class \Thruway\Transport\AbstractTransport and the interface \Thruway\Transport\TransportInterface should be moved to voryx/thruway-common and "voryx/thruway-common": "*" should be added as require-dev to all transports, including thruway/ratchet-transport.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant