new redeem stackable object type #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinrog
changed the title
p-zielinski
requested changes
Nov 21, 2024
| metadata?: Record<string, any> | ||
| result: 'SUCCESS' | 'FAILURE' | ||
| voucher?: VouchersResponse | ||
| customer?: SimpleCustomer |
p-zielinski
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Potestowałem i znalazłem sporo błędów:
By zobaczyć te błędy u siebie podmień:
packages/sdk/src/Redemptions.ts
import * as T from './types/Redemptions'
import { encode, isObject, isString } from './helpers'
import type { RequestController } from './RequestController'
export class Redemptions {
constructor(private client: RequestController) {}
/**
* @see https://docs.voucherify.io/reference/redeem-voucher
*/
public redeem(code: string, body: T.RedemptionsRedeemBody = {}) {
return this.client.post<T.RedemptionsRedeemResponse>(`/vouchers/${encode(code)}/redemption`, body)
}
/**
* @see https://docs.voucherify.io/reference/redeem-stacked-discounts
*/
public redeemStackable(params: T.RedemptionsRedeemStackableParams) {
const x: T.RedemptionsRedeemStackableResponse = {
redemptions: [
{
id: 'r_0fbe41b248d2d11481',
date: '2024-11-28T09:25:43.843Z',
order: {
id: 'ord_0fbe41b24252d1147a',
source_id: null,
status: 'PAID',
customer_id: null,
referrer_id: null,
applied_discount_amount: 0,
total_applied_discount_amount: 0,
metadata: {},
created_at: '2024-11-28T09:25:43.820Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:25:43.836Z',
redemption: {
quantity: null,
redeemed_quantity: 1,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
],
order: {
id: 'ord_0fbe41b24252d1147a',
source_id: null,
created_at: '2024-11-28T09:25:43.820Z',
updated_at: null,
status: 'PAID',
applied_discount_amount: 0,
total_applied_discount_amount: 0,
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe41b248d2d11481: {
date: '2024-11-28T09:25:43.843Z',
related_object_type: 'voucher',
related_object_id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
related_object_parent_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
},
},
},
inapplicable_redeemables: [],
skipped_redeemables: [],
}
const y: T.RedemptionsRedeemStackableResponse = {
redemptions: [
{
id: 'r_0fbe4384b90de6c277',
date: '2024-11-28T09:33:41.476Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:33:41.471Z',
redemption: {
quantity: null,
redeemed_quantity: 1,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4384b78de6c276',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
{
id: 'r_0fbe4384b90de6c278',
date: '2024-11-28T09:33:41.476Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
promotion_tier: {
id: 'promo_5uagb1IBw3NFSu8Jjff1ilv6',
name: 'xyz3',
banner: null,
campaign: {
id: 'camp_07Hi8xj8x4KUtKbvYNLW1QL6',
},
metadata: {},
},
redemption: 'r_0fbe4384b78de6c276',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
],
parent_redemption: {
id: 'r_0fbe4384b78de6c276',
date: '2024-11-28T09:33:41.476Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
status: 'PAID',
customer_id: null,
referrer_id: null,
applied_discount_amount: 0,
total_applied_discount_amount: 0,
metadata: {},
created_at: '2024-11-28T09:33:41.461Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
created_at: '2024-11-28T09:33:41.461Z',
updated_at: null,
status: 'PAID',
applied_discount_amount: 0,
total_applied_discount_amount: 0,
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe4384b78de6c276: {
date: '2024-11-28T09:33:41.476Z',
related_object_type: 'redemption',
related_object_id: 'r_0fbe4384b78de6c276',
stacked: ['r_0fbe4384b90de6c277', 'r_0fbe4384b90de6c278'],
},
},
},
inapplicable_redeemables: [
{
status: 'INAPPLICABLE',
id: 'xyz2',
object: 'voucher',
result: {
error: {
code: 400,
key: 'missing_amount',
message: 'Missing amount',
details: 'Amount is required when redeeming a GIFT_VOUCHER',
request_id: 'v-0fbe4384ad0aaf3e29',
},
details: {
message: 'Missing amount',
key: 'missing_amount',
},
},
metadata: {},
},
],
skipped_redeemables: [],
}
const z: T.RedemptionsRedeemStackableResponse = {
redemptions: [
{
id: 'r_0fbe4416a1d09bca64',
date: '2024-11-28T09:36:10.887Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
discount_amount: 0,
applied_discount_amount: 0,
total_discount_amount: 0,
total_applied_discount_amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:36:10.880Z',
redemption: {
quantity: null,
redeemed_quantity: 3,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4416a0109bca5d',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
{
id: 'r_0fbe4416a1d09bca65',
date: '2024-11-28T09:36:10.887Z',
amount: 0,
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
discount_amount: 0,
applied_discount_amount: 0,
total_discount_amount: 0,
total_applied_discount_amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_zR2b98EZ37iWq26mrmo37QeDI6lL7wjU',
code: 'XYZ2',
gift: {
amount: 200,
balance: 200,
effect: 'APPLY_TO_ORDER',
},
type: 'GIFT_VOUCHER',
campaign: 'xyz2',
campaign_id: 'camp_sIGFWgbFbuSq8uYDl4zF9UAF',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:32:09.449Z',
updated_at: '2024-11-28T09:36:10.880Z',
redemption: {
quantity: null,
redeemed_quantity: 1,
redeemed_amount: 0,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4416a0109bca5d',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
{
id: 'r_0fbe4416a1d09bca66',
date: '2024-11-28T09:36:10.887Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
discount_amount: 0,
applied_discount_amount: 0,
total_discount_amount: 0,
total_applied_discount_amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
promotion_tier: {
id: 'promo_5uagb1IBw3NFSu8Jjff1ilv6',
name: 'xyz3',
banner: null,
campaign: {
id: 'camp_07Hi8xj8x4KUtKbvYNLW1QL6',
},
metadata: {},
},
redemption: 'r_0fbe4416a0109bca5d',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
],
parent_redemption: {
id: 'r_0fbe4416a0109bca5d',
date: '2024-11-28T09:36:10.887Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
status: 'PAID',
customer_id: null,
referrer_id: null,
amount: 0,
discount_amount: 0,
applied_discount_amount: 0,
total_discount_amount: 0,
total_applied_discount_amount: 0,
total_amount: 0,
metadata: {},
created_at: '2024-11-28T09:36:10.848Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
metadata: {
sale_channel: 'kiosk',
store_id: 'AC',
order_serving_mode: 'Take Away',
store_aloha_id: '048',
store_name: 'AC',
},
object: 'redemption',
},
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
created_at: '2024-11-28T09:36:10.848Z',
updated_at: null,
status: 'PAID',
amount: 0,
discount_amount: 0,
total_discount_amount: 0,
total_amount: 0,
applied_discount_amount: 0,
total_applied_discount_amount: 0,
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe4416a0109bca5d: {
date: '2024-11-28T09:36:10.887Z',
related_object_type: 'redemption',
related_object_id: 'r_0fbe4416a0109bca5d',
stacked: ['r_0fbe4416a1d09bca64', 'r_0fbe4416a1d09bca65', 'r_0fbe4416a1d09bca66'],
},
},
},
inapplicable_redeemables: [],
skipped_redeemables: [],
}
return this.client.post<T.RedemptionsRedeemStackableResponse>(`/redemptions`, params)
}
/**
* @see https://docs.voucherify.io/reference/get-redemption
*/
public get(redemptionId: string) {
return this.client.get<T.Redemption>(`/redemptions/${encode(redemptionId)}`)
}
/**
* @see https://docs.voucherify.io/reference/list-redemptions
*/
public list(params: T.RedemptionsListParams = {}) {
return this.client.get<T.RedemptionsListResponse>('/redemptions', params)
}
/**
* @see https://docs.voucherify.io/reference/vouchers-redemptions
*/
public getForVoucher(code: string) {
return this.client.get<T.RedemptionsGetForVoucherResponse>(`/vouchers/${encode(code)}/redemption`)
}
/**
* @see https://docs.voucherify.io/reference/rollback-redemption
*/
public rollback(redemptionId: string, params?: T.RedemptionsRollbackParams) {
let queryParams: T.RedemptionsRollbackQueryParams = {}
let payload: T.RedemptionsRollbackPayload = {}
if (isString(params)) {
queryParams.reason = params
} else if (isObject(params)) {
const { reason, tracking_id: trackingId, customer } = params
queryParams = {
reason: reason ? reason : undefined,
tracking_id: trackingId ? trackingId : undefined,
}
payload = { customer }
}
return this.client.post<T.RedemptionsRollbackResponse>(
`/redemptions/${encode(redemptionId)}/rollback`,
payload,
queryParams,
)
}
/**
* @see https://docs.voucherify.io/reference/rollback-stackable-redemptions
* Types of params and queryParams WILL be changed in future - please do not depend on it!
*/
public rollbackStackable(parentRedemptionId: string, params?: any, queryParams?: any) {
const x: T.RedemptionsRollbackStackableResponse = {
rollbacks: [
{
id: 'rr_0fbe42b66fcde6a5b1',
date: '2024-11-28T09:30:10.281Z',
order: {
id: 'ord_0fbe41b24252d1147a',
source_id: null,
status: 'CANCELED',
customer_id: null,
referrer_id: null,
metadata: {},
created_at: '2024-11-28T09:25:43.820Z',
updated_at: '2024-11-28T09:30:10.286Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:30:10.278Z',
redemption: {
quantity: null,
redeemed_quantity: 0,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe41b248d2d11481',
metadata: null,
object: 'redemption_rollback',
},
],
order: {
id: 'ord_0fbe41b24252d1147a',
source_id: null,
created_at: '2024-11-28T09:25:43.820Z',
updated_at: '2024-11-28T09:30:10.286Z',
status: 'CANCELED',
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe41b248d2d11481: {
date: '2024-11-28T09:25:43.843Z',
rollback_id: 'rr_0fbe42b66fcde6a5b1',
rollback_date: '2024-11-28T09:30:10.281Z',
related_object_type: 'voucher',
related_object_id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
related_object_parent_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
},
},
},
}
const y: T.RedemptionsRollbackStackableResponse = {
rollbacks: [
{
id: 'rr_0fbe447a7b4de6e3eb',
date: '2024-11-28T09:37:53.133Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:37:53.125Z',
redemption: {
quantity: null,
redeemed_quantity: 1,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4384b90de6c277',
metadata: null,
object: 'redemption_rollback',
},
{
id: 'rr_0fbe447a7b4de6e3ec',
date: '2024-11-28T09:37:53.133Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
promotion_tier: {
id: 'promo_5uagb1IBw3NFSu8Jjff1ilv6',
name: 'xyz3',
banner: null,
campaign: {
id: 'camp_07Hi8xj8x4KUtKbvYNLW1QL6',
},
metadata: {},
},
redemption: 'r_0fbe4384b90de6c278',
metadata: null,
object: 'redemption_rollback',
},
],
parent_rollback: {
id: 'rr_0fbe447a708de6e3e7',
date: '2024-11-28T09:37:53.090Z',
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
status: 'CANCELED',
customer_id: null,
referrer_id: null,
metadata: {},
created_at: '2024-11-28T09:33:41.461Z',
updated_at: '2024-11-28T09:37:53.143Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
redemption: 'r_0fbe4384b78de6c276',
metadata: null,
object: 'redemption_rollback',
},
order: {
id: 'ord_0fbe4384b10de6c265',
source_id: null,
created_at: '2024-11-28T09:33:41.461Z',
updated_at: '2024-11-28T09:37:53.155Z',
status: 'CANCELED',
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe4384b78de6c276: {
date: '2024-11-28T09:33:41.476Z',
rollback_id: 'rr_0fbe447a708de6e3e7',
rollback_date: '2024-11-28T09:37:53.090Z',
related_object_type: 'redemption',
related_object_id: 'r_0fbe4384b78de6c276',
stacked: ['r_0fbe4384b90de6c277', 'r_0fbe4384b90de6c278'],
rollback_stacked: ['rr_0fbe447a7b4de6e3eb', 'rr_0fbe447a7b4de6e3ec'],
},
},
},
}
const z: T.RedemptionsRollbackStackableResponse = {
rollbacks: [
{
id: 'rr_0fbe444ee9909bd149',
date: '2024-11-28T09:37:08.518Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_8ZKDUCPNXbVWcoYdc7qtJmNILaq20730',
code: 'XYZ1',
discount: {
type: 'AMOUNT',
amount_off: 100,
effect: 'APPLY_TO_ORDER',
},
type: 'DISCOUNT_VOUCHER',
campaign: 'xyz1',
campaign_id: 'camp_DytAZkSytZiLXgW47l6AAMnh',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:24:42.386Z',
updated_at: '2024-11-28T09:37:08.512Z',
redemption: {
quantity: null,
redeemed_quantity: 2,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4416a1d09bca64',
metadata: null,
object: 'redemption_rollback',
},
{
id: 'rr_0fbe444ee9909bd14a',
date: '2024-11-28T09:37:08.518Z',
amount: 0,
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
discount_amount: 0,
total_discount_amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
voucher: {
id: 'v_zR2b98EZ37iWq26mrmo37QeDI6lL7wjU',
code: 'XYZ2',
gift: {
amount: 200,
balance: 200,
effect: 'APPLY_TO_ORDER',
},
type: 'GIFT_VOUCHER',
campaign: 'xyz2',
campaign_id: 'camp_sIGFWgbFbuSq8uYDl4zF9UAF',
is_referral_code: false,
category_id: null,
active: true,
created_at: '2024-11-28T09:32:09.449Z',
updated_at: '2024-11-28T09:37:08.512Z',
redemption: {
quantity: null,
redeemed_quantity: 0,
redeemed_amount: 0,
},
start_date: null,
expiration_date: null,
metadata: {},
object: 'voucher',
},
redemption: 'r_0fbe4416a1d09bca65',
metadata: null,
object: 'redemption_rollback',
},
{
id: 'rr_0fbe444ee9909bd14b',
date: '2024-11-28T09:37:08.518Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
amount: 0,
discount_amount: 0,
total_discount_amount: 0,
total_amount: 0,
metadata: {},
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
promotion_tier: {
id: 'promo_5uagb1IBw3NFSu8Jjff1ilv6',
name: 'xyz3',
banner: null,
campaign: {
id: 'camp_07Hi8xj8x4KUtKbvYNLW1QL6',
},
metadata: {},
},
redemption: 'r_0fbe4416a1d09bca66',
metadata: null,
object: 'redemption_rollback',
},
],
parent_rollback: {
id: 'rr_0fbe444ee6109bd143',
date: '2024-11-28T09:37:08.504Z',
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
status: 'CANCELED',
customer_id: null,
referrer_id: null,
amount: 0,
total_amount: 0,
metadata: {},
created_at: '2024-11-28T09:36:10.848Z',
updated_at: '2024-11-28T09:37:08.522Z',
object: 'order',
},
result: 'SUCCESS',
status: 'SUCCEEDED',
redemption: 'r_0fbe4416a0109bca5d',
metadata: null,
object: 'redemption_rollback',
},
order: {
id: 'ord_0fbe441694d09bca4e',
source_id: null,
created_at: '2024-11-28T09:36:10.848Z',
updated_at: '2024-11-28T09:37:08.529Z',
status: 'CANCELED',
amount: 0,
total_amount: 0,
metadata: {},
customer_id: null,
referrer_id: null,
object: 'order',
redemptions: {
r_0fbe4416a0109bca5d: {
date: '2024-11-28T09:36:10.887Z',
rollback_id: 'rr_0fbe444ee6109bd143',
rollback_date: '2024-11-28T09:37:08.504Z',
related_object_type: 'redemption',
related_object_id: 'r_0fbe4416a0109bca5d',
stacked: ['r_0fbe4416a1d09bca64', 'r_0fbe4416a1d09bca65', 'r_0fbe4416a1d09bca66'],
rollback_stacked: ['rr_0fbe444ee9909bd149', 'rr_0fbe444ee9909bd14a', 'rr_0fbe444ee9909bd14b'],
},
},
},
}
return this.client.post<T.RedemptionsRollbackStackableResponse>(
`/redemptions/${encode(parentRedemptionId)}/rollbacks`,
params,
queryParams,
)
}
}
|
Testowałem na 6 requestach. |
|
Nawiązując do naszej rozmowy brakuje w paru miejscach |
p-zielinski
reviewed
Nov 28, 2024
| redemptions?: Record< | ||
| string, | ||
| { | ||
| date: string | ||
| rollback_id?: string | ||
| rollback_date?: string | ||
| related_object_type: 'redemption' | ||
| related_object_type: 'redemption' | 'voucher' | 'promotion_tier' |
There was a problem hiding this comment.
a promotion_stack nie?
There was a problem hiding this comment.
dokumentacja nic nie mówi o takim unionie niestety, więc nie wiem
There was a problem hiding this comment.
Chodziło o to byś sprawdził, robiąc redeema z promotion stackiem:
Ja teraz zrobiłem i jest:
więc proszę dodaj promotion_stack jako możliwość
p-zielinski
approved these changes
Nov 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
The new
RedemptionsRedeemStackableRedemptionResultobject type, which is separated from theRedemptionsRedeemResponsetype as aredeem-vouchermethod is deprecated.In connection with this change
RedemptionsRedeemStackableRedemptionResulthas been enriched with the new types (as the documentation tells).WHY
Regarding the Slack discussion about Shutterstock company. In that case we should create a new object type only for stackable operations.