Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Puppet 8x support #74

Closed
flepoutre opened this issue May 30, 2023 · 3 comments
Closed

Puppet 8x support #74

flepoutre opened this issue May 30, 2023 · 3 comments

Comments

@flepoutre
Copy link

flepoutre commented May 30, 2023

Hi,
Is it possible to update module with a new tag for Puppet 8x support ?

In my testing env I have changed this in params.pp :
- case $::osfamily {
+ case $facts['os']['family'] {
- fail("Unsupported osfamily (${::osfamily})")
+ fail("Unsupported osfamily (${facts['os']['family']})")

Thanks

@pcfens
Copy link
Contributor

pcfens commented Jun 1, 2023

Since you've already done most of the work required could you submit that as a pull request? I'd be happy to merge it quickly.

I don't have a Puppet 8 test environment yet, so I won't be able to do the work myself anytime soon.

@toadstule
Copy link
Contributor

Here's a PR to replace the legacy facts:

#75

@pcfens
Copy link
Contributor

pcfens commented Jun 13, 2023

Thanks. Fixed by #75.

@pcfens pcfens closed this as completed Jun 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants