diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e6b180080..428337985 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -37,11 +37,6 @@ Style/AccessorMethodName: - 'lib/puppet/provider/jenkins_authorization_strategy/cli.rb' - 'lib/puppet/provider/jenkins_security_realm/cli.rb' -# Offense count: 1 -Style/DoubleNegation: - Exclude: - - 'lib/puppet/provider/jenkins_job/cli.rb' - # Offense count: 33 # Configuration parameters: AllowedVariables. Style/GlobalVars: diff --git a/lib/puppet/provider/jenkins_job/cli.rb b/lib/puppet/provider/jenkins_job/cli.rb index 78843e269..e83454c85 100644 --- a/lib/puppet/provider/jenkins_job/cli.rb +++ b/lib/puppet/provider/jenkins_job/cli.rb @@ -78,7 +78,8 @@ def self.get_job(job, catalog = nil) # currently unused def self.job_enabled(job, catalog = nil) raw = clihelper(['job_enabled', job], catalog: catalog) - !!(raw =~ %r{true}) + return true if raw =~ %r{true} + false end private_class_method :job_enabled