Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Darwin/osx support #112

Closed
bjjsre opened this issue Mar 12, 2014 · 4 comments
Closed

Darwin/osx support #112

bjjsre opened this issue Mar 12, 2014 · 4 comments
Labels
enhancement New feature or request

Comments

@bjjsre
Copy link

bjjsre commented Mar 12, 2014

I came up with basic slave support for darwin:
https://github.com/b2jrock/puppet-jenkins_darwin

We should merge this in.. major differences are:

  • Java support - need to install from dmg
  • a few more options to the swarm plugin

TODOs:

  • Complete lack of tests
  • Master support (?)
@matthewbarr
Copy link
Contributor

First question: Where do you get the DMG?

If you can find an automated way to get it, I'd see about adding it as a pull request to the puppetlabs/java module - https://github.com/puppetlabs/puppetlabs-java

2nd: you're going to have failures from package ( $java_package:... } commented out, because of the chain at the end.

  1. How about taking the current slave module, and using that to add the support? The trivial case would be to have a OSFamily IF in the module. not sure if it'd be better to use classes underneath, but it might get too messy. Have to go look at the init scripts, anyways, from debian compatibility and variable use #65
  2. You may want to base the work off the current manifest, which is much more conducive to this. (it can not install java, which would mean that you could manage java outside the module, for one thing..)

@rtyler
Copy link

rtyler commented Mar 13, 2014

@matthewbarr You responded quite quickly! I asked @b2jrock to open this up for us to discuss. I'm not currently in possession of a modern enough Mac to test any of this stuff, but I think making Darwin slave support work is a worthwhile effort :)

@matthewbarr
Copy link
Contributor

I am in possession of a new mac, but this code needs to be integrated into our code base, first.

I've run the slave on a mac about a year ago, and it works w/o issue. I didn't bother getting the launchd scripts for it written, though..

@jhoblitt
Copy link
Member

osx slave support was merged as #351.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants