Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove /* #__PURE__*/ comments #7156

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

0xJacky
Copy link
Contributor

@0xJacky 0xJacky commented Dec 2, 2023

这个变动的性质是

  • 日常 bug 修复

需求背景

使用 Vite 5 打包时出现 Warning 提示 /* #__PURE__*/ comment 被移除
相关文件 components/_util/hooks/_vueuse/_configurable.ts, components/_util/hooks/_vueuse/is.ts

相关 Issues:

  1. vite 5.0.2 打包config文件被移除 #7132
  2. 5.0.2 build can not work vitejs/vite#15100 (comment)

实现方案和 API

移除 /* #__PURE__*/

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@kaokei
Copy link

kaokei commented Dec 4, 2023

@0xJacky 如果我没有理解错误的话,这里的注解应该删除掉才是正确的处理方式。因为我们这里的代码并不适用于
/* #__PURE__*//* #__NO_SIDE_EFFECTS__ */

参考这里:

  1. https://rollupjs.org/migration/#general-changes
  2. https://rollupjs.org/configuration-options/#pure

@0xJacky
Copy link
Contributor Author

0xJacky commented Dec 6, 2023

好的,已经移除了

@0xJacky 0xJacky changed the title fix: replace /* #__PURE__*/ comment with /* #__NO_SIDE_EFFECTS__ */ fix: remove /* #__PURE__*/ comments Dec 6, 2023
@tangjinzhou tangjinzhou merged commit 562623c into vueComponent:main Dec 18, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants