Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] 1.x 版本上，可以做一个变更吗 #212

Closed
tu6ge opened this issue Apr 13, 2022 · 3 comments
Closed

[Feature] 1.x 版本上，可以做一个变更吗 #212

tu6ge opened this issue Apr 13, 2022 · 3 comments
Labels
feature New feature or request

Comments

@tu6ge
Copy link

tu6ge commented Apr 13, 2022

🥰 需求描述 Description of Requirement

siderWidth 需要传 14rem，但是现在格式要求是数字

🧐 解决方案 Solution

改下 siderWidth prop 的格式要求为 any

🚑 其他信息 Other information

可以再发一个 1.x的小版本吗？我自己提pr
@tu6ge tu6ge added the feature New feature or request label Apr 13, 2022
@sendya
Copy link
Member

sendya commented Apr 13, 2022

我不太清楚 siderWidth 直接传递给 Layout.Sider 组件是否会有异常，你可以先尝试一下~

@tu6ge
Copy link
Author

tu6ge commented Apr 14, 2022

能否提供一个 PR 指南，我可以通过这个指南方便的跑起来 fork 的代码，进而验证我所做的变更

@sendya
Copy link
Member

sendya commented Apr 14, 2022

升级到 1.0.12 即可

@tu6ge tu6ge closed this as completed Apr 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tu6ge @sendya