Skip to content

Commit 08f0fcd

Browse files
committed
fix: use shallowRef on result & error
1 parent fda4c9f commit 08f0fcd

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

packages/vue-apollo-composable/src/useMutation.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { DocumentNode } from 'graphql'
22
import { MutationOptions, OperationVariables, FetchResult, TypedDocumentNode, ApolloError, ApolloClient } from '@apollo/client/core/index.js'
3-
import { ref, onBeforeUnmount, isRef, Ref, getCurrentInstance } from 'vue-demi'
3+
import { ref, onBeforeUnmount, isRef, Ref, getCurrentInstance, shallowRef } from 'vue-demi'
44
import { useApolloClient } from './useApolloClient'
55
import { ReactiveFunction } from './util/ReactiveFunction'
66
import { useEventHook } from './util/useEventHook'
@@ -56,7 +56,7 @@ export function useMutation<
5656
const vm = getCurrentInstance()
5757
const loading = ref<boolean>(false)
5858
vm && trackMutation(loading)
59-
const error = ref<ApolloError | null>(null)
59+
const error = shallowRef<ApolloError | null>(null)
6060
const called = ref<boolean>(false)
6161

6262
const doneEvent = useEventHook<[FetchResult<TResult, Record<string, any>, Record<string, any>>, OnDoneContext]>()

packages/vue-apollo-composable/src/useQuery.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ export function useQueryImpl<
165165
/**
166166
* Result from the query
167167
*/
168-
const result = ref<TResult | undefined>()
168+
const result = shallowRef<TResult | undefined>()
169169
const resultEvent = useEventHook<[ApolloQueryResult<TResult>, OnResultContext]>()
170-
const error = ref<ApolloError | null>(null)
170+
const error = shallowRef<ApolloError | null>(null)
171171
const errorEvent = useEventHook<[ApolloError, OnErrorContext]>()
172172

173173
// Loading

packages/vue-apollo-composable/src/useSubscription.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
getCurrentInstance,
99
onBeforeUnmount,
1010
nextTick,
11+
shallowRef,
1112
} from 'vue-demi'
1213
import type {
1314
OperationVariables,
@@ -127,9 +128,9 @@ export function useSubscription <
127128
const variablesRef = paramToRef(variables)
128129
const optionsRef = paramToReactive(options)
129130

130-
const result = ref<TResult | null | undefined>()
131+
const result = shallowRef<TResult | null | undefined>()
131132
const resultEvent = useEventHook<[FetchResult<TResult>, OnResultContext]>()
132-
const error = ref<ApolloError | null>(null)
133+
const error = shallowRef<ApolloError | null>(null)
133134
const errorEvent = useEventHook<[ApolloError, OnErrorContext]>()
134135

135136
const loading = ref(false)

0 commit comments

Comments
 (0)