Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(custom-element): props can be casted when mounting custom elements in component rendering functions #11082

Closed
wants to merge 9 commits into from

Conversation

baiwusanyu-c
Copy link
Member

close: #11081

@baiwusanyu-c
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 7, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant failure failure
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Copy link

github-actions bot commented Jul 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.5 kB (+163 B) 34.2 kB (+53 B) 30.9 kB (+69 B)
vue.global.prod.js 146 kB (+163 B) 53.6 kB (+58 B) 47.8 kB (+125 B)

Usages

Name Size Gzip Brotli
createApp 51.4 kB (+75 B) 20.1 kB (+31 B) 18.3 kB (+31 B)
createSSRApp 54.8 kB (+75 B) 21.5 kB (+28 B) 19.5 kB (+17 B)
defineCustomElement 53.8 kB (+163 B) 20.9 kB (+49 B) 19 kB (+33 B)
overall 65.1 kB (+75 B) 25.2 kB (+40 B) 22.8 kB (+43 B)

@edison1105 edison1105 added the ready for review This PR requires more reviews label Aug 6, 2024
yyx990803 added a commit that referenced this pull request Aug 8, 2024
@yyx990803
Copy link
Member

closed via a07e7bf

@yyx990803 yyx990803 closed this Aug 8, 2024
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/async-props-ce branch August 8, 2024 09:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready for review This PR requires more reviews scope: custom elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【custom-element】wrong props casting when rendering async custom elements in SFC
4 participants