Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(reactivity): ensure stop and once same behavior #11665

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

yangxiuxiu1115
Copy link
Contributor

Not sure if this is intentional, but I think the destruction logic of once should be consistent with stop

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB (-10 B) 37.5 kB (-3 B) 33.8 kB (+28 B)
vue.global.prod.js 157 kB (-10 B) 57.3 kB (-4 B) 51 kB (-12 B)

Usages

Name Size Gzip Brotli
createApp 54.5 kB (-10 B) 21.1 kB (-4 B) 19.3 kB (+3 B)
createSSRApp 58.4 kB (-10 B) 22.8 kB (-4 B) 20.8 kB (+7 B)
defineCustomElement 59.1 kB (-10 B) 22.6 kB (-5 B) 20.6 kB (-9 B)
overall 68.1 kB (-10 B) 26.2 kB (-20 B) 23.8 kB (+36 B)

Copy link

pkg-pr-new bot commented Aug 20, 2024

commit: 91e8196

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11665

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11665

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11665

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11665

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11665

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11665

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11665

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11665

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11665

vue

pnpm add https://pkg.pr.new/vue@11665

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11665

Open in Stackblitz

@yyx990803
Copy link
Member

Good catch, can you add a test case for this behavior?

@yyx990803 yyx990803 merged commit fbc0c42 into vuejs:main Aug 20, 2024
13 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/watch branch August 20, 2024 10:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants