Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(runtime-core): reset keep alive flag when the component is removed from include #11718

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

linzhe141
Copy link
Contributor

close #11717

@linzhe141 linzhe141 changed the title fix(runtime-core): When the component does not change keepalive, it should be excluded fix(runtime-core): When a component should not be keepalive, it should be excluded Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB (+18 B) 37.5 kB (+11 B) 33.8 kB (-22 B)
vue.global.prod.js 157 kB (+18 B) 57.3 kB (+9 B) 51 kB (-29 B)

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB (+18 B) 26.2 kB (+13 B) 23.8 kB (-25 B)

Copy link

pkg-pr-new bot commented Aug 26, 2024

commit: f664639

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11718

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11718

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11718

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11718

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11718

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11718

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11718

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11718

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11718

vue

pnpm add https://pkg.pr.new/vue@11718

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11718

Open in Stackblitz

@skirtles-code
Copy link
Contributor

Could you add a test for this?

@edison1105 edison1105 added need test The PR has missing test cases. scope: keep-alive 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Aug 27, 2024
@edison1105 edison1105 changed the title fix(runtime-core): When a component should not be keepalive, it should be excluded fix(runtime-core): reset keep alive flag when the component is removed from include Aug 27, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed need test The PR has missing test cases. labels Aug 27, 2024
@yyx990803 yyx990803 merged commit 29c321b into vuejs:main Aug 29, 2024
13 checks passed
@linzhe141 linzhe141 deleted the fix-keepalive branch August 29, 2024 05:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: keep-alive
Projects
None yet
4 participants