Skip to content

fix(backend): ensure currentAppRecord is defined when backend handli… #2070

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

dO-ob94
Copy link
Contributor

@dO-ob94 dO-ob94 commented May 25, 2023

…ng components events emitted from Vue. (fix #1770)

Description

I have noticed that there are some issues caused by the reason that currentAppRecord is not defined (but it is used when some hooks such as COMPONENT_ADDED are called). Typical issues are #1770 and #1711. And there is good case analysis.

I had same issue when I developed a Micro Frontends project which contains both Vue2 and Vue3 app instance. And I found that selectApp function is almost a synchronous function. So I just change the order of code execution in createAppRecord function then errors disappeared.

@yyx990803 吐槽一下,这个二十几k星项目的文档还有很大的提升空间。

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@dO-ob94 dO-ob94 marked this pull request as ready for review May 25, 2023 09:04
@Akryum Akryum changed the title fix(backends): ensure currentAppRecord is defined when backend handli… fix(backend): ensure currentAppRecord is defined when backend handli… Feb 4, 2024
@Akryum Akryum merged commit b954f66 into vuejs:main Feb 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in console
2 participants