Skip to content

fix(iframe): Add optional chaining on unsafe-type element #2092

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

Azurewarth0920
Copy link
Contributor

Description

Fix: #2078

Check the existence of the root element as the root element may be empty.
(Eg. described in #2078, using custom render that doesn't generate DOM may cause the empty root)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum Akryum changed the title fix: Add optional chaining on unsafe-type element fix(iframe): Add optional chaining on unsafe-type element Feb 4, 2024
@Akryum Akryum merged commit 417e5ef into vuejs:main Feb 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devtools break with instance using custom renderer TresJS (no DOM)
2 participants