Skip to content

Maybe a breaking change #112

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wjq990112 opened this issue Jul 2, 2021 · 11 comments · Fixed by #113
Closed

Maybe a breaking change #112

wjq990112 opened this issue Jul 2, 2021 · 11 comments · Fixed by #113

Comments

@wjq990112
Copy link

wjq990112 commented Jul 2, 2021

dependence espree is a breaking change, which is only support node version >= 12.

@wjq990112 wjq990112 changed the title Maybe a breaking change. Maybe a breaking change Jul 2, 2021
@ota-meshi
Copy link
Member

When used with ESLint, it does not actually use the dependent espree. So I thought it wasn't a breaking change, but isn't it?

@Benoit-Vasseur
Copy link

vue create seems broken because of espressV8 => vuejs/vue-cli#6562 (comment) (depending of the node version you have). So it has some impact ^^

@wjq990112
Copy link
Author

When used with ESLint, it does not actually use the dependent espree. So I thought it wasn't a breaking change, but isn't it?

It will fail when npm install, because of node version.

@haoqunjiang
Copy link
Member

Yarn treats the engines field very strictly, so Yarn users with old Node.js versions will be affected.

So technically, we need a semver major bump for the change.

But please, update your Node version in this case…
Node.js 10 has reached End-of-Life long ago.

@haoqunjiang
Copy link
Member

It will fail when npm install, because of node version.

It won't. engine-strict defaults to false in NPM.
https://docs.npmjs.com/cli/v7/using-npm/config#engine-strict

@wjq990112
Copy link
Author

It won't. engine-strict defaults to false in NPM.
https://docs.npmjs.com/cli/v7/using-npm/config#engine-strict

Sorry, mistyped, it will fail when yarn install.

@Benoit-Vasseur
Copy link

Benoit-Vasseur commented Jul 2, 2021

The engine requirements of espreeV8 is very strict : Expected version "^12.22.0 || ^14.17.0 || >=16.0.0"

So it fails if you use yarn v1 and node v12.21 or 14.16.0 for exemple :/

@Benoit-Vasseur
Copy link

The engine requirements of espreeV8 is very strict : Expected version "^12.22.0 || ^14.17.0 || >=16.0.0"

So it fails if you use yarn and node v12.21 or 14.16.0 for exemple :/

@haoqunjiang
Copy link
Member

Workaround:

Create a .yarnrc file in the project root, with the following content:

--install.ignore-engines true

@wjq990112
Copy link
Author

But in this package:

engines version is

"engines": {
  "node": ">=8.10"
},

but dependence espree is ^12.22.0 || ^14.17.0 || >=16.0.0.

Is that correct?

@ota-meshi
Copy link
Member

I make a fix that downgrades the espree dependency.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants