fix: ensure new webpack5 generator property in rules passes ruleset checks (v15) #1753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack 5 has a new property in rule definitions called
generator
- we need to account for that in the rule validiations we have in place.Note this is for vue-loader 15, targeting Vue 2. Matching PR for v16: #1754
Tests
I wasn't sure how to test for this as the repo's webpack version is locked to v4, and the property only exists in v5.
I locally changed the webpack version to v5, added the following rule to the test cases base config and ran the tests:
... multiple tests broke without my change, and all tests passed after my change.
close #1729