Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ensure new webpack5 generator property in rules passes ruleset checks (v15) #1753

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Oct 28, 2020

Webpack 5 has a new property in rule definitions called generator - we need to account for that in the rule validiations we have in place.

Note this is for vue-loader 15, targeting Vue 2. Matching PR for v16: #1754

Tests

I wasn't sure how to test for this as the repo's webpack version is locked to v4, and the property only exists in v5.

I locally changed the webpack version to v5, added the following rule to the test cases base config and ran the tests:

{
  test: /\.tiff$/,
  type: 'asset/resource',
  generator: {
    filename: '[hash][ext][query]'
  }
}

... multiple tests broke without my change, and all tests passed after my change.

close #1729

@LinusBorg LinusBorg changed the title fix: ensure new webpack5 generator property in rules passes ruleset checks fix: ensure new webpack5 generator property in rules passes ruleset checks (v15) Oct 28, 2020
@haoqunjiang haoqunjiang merged commit f79bb08 into master Oct 29, 2020
@haoqunjiang haoqunjiang deleted the linusborg/fix-generator-prop-1729 branch October 29, 2020 08:11
d3x42 pushed a commit to JetBrains/svg-sprite-loader that referenced this pull request May 6, 2021
In Webpack 5 a new property "generator" has been added to the rule definition, which must be accounted for in the rule set.

Fixes #428. (See  vuejs/vue-loader#1753)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack@5 asset generator property not supported
2 participants