Skip to content

fix(router-view): add condition to see whether the tree is inactive (fix #2552) #2592

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Jan 22, 2019

close #2552

@posva
Copy link
Member

posva commented Jan 22, 2019

Thanks! Could you add a test case for this? e2e should be easier for the moment for this one

@zrh122
Copy link
Contributor Author

zrh122 commented Jan 22, 2019

Thanks! Could you add a test case for this? e2e should be easier for the moment for this one

Yes, i will

@zrh122
Copy link
Contributor Author

zrh122 commented Jan 23, 2019

@posva , e2e test added.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will do some minor modifications locally

@posva posva merged commit e6d8fd2 into vuejs:dev Apr 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested router-view renders incorrect component with wrapping keep-alive at root
2 participants