Skip to content

fix(router-view): add passing props to inactive component #2773

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jan 15, 2020

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented May 20, 2019

Add passing props to inactive component. it closes #2301.

@zrh122 zrh122 force-pushed the fix-keepalive-props branch from b58940c to a302a33 Compare June 15, 2019 13:55
@posva
Copy link
Member

posva commented Jan 14, 2020

@zrh122 Could you give this a new look and fix the merge conflicts please?

@zrh122 zrh122 force-pushed the fix-keepalive-props branch from a302a33 to b2429ab Compare January 14, 2020 13:08
@zrh122
Copy link
Contributor Author

zrh122 commented Jan 14, 2020

@zrh122 Could you give this a new look and fix the merge conflicts please?

@posva I have resolved.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was so fast! Thank you for the PR, it looks good, I refactored things a little bit (mostly naming) and added a few tests

@posva posva merged commit 0fb1343 into vuejs:dev Jan 15, 2020
@zrh122
Copy link
Contributor Author

zrh122 commented Jan 15, 2020

Thanks so much 👏.

@zrh122 zrh122 deleted the fix-keepalive-props branch January 15, 2020 12:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested props are marked as missing when changing route and using keep-alive
2 participants