-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: create stubs in createElement #1038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! After this change I'm getting stubbed components on mounted (not shallow) components if the component was previously shallow mounted (on another test). it('renders the component without stubs', () => {
const wrapper = mount(TheComponent, { store, localVue, propsData: {…} });
// The component has no stubs, as expected
}
it('renders the component again without stubs', () => {
const wrapper = mount(TheComponent, { store, localVue, propsData: {…} });
// The component has no stubs, as expected
} But: it('renders the component with stubs', () => {
const wrapper = shallowMount(TheComponent, { store, localVue, propsData: {…} });
// The component has stubs, as expected
}
it('renders the component with stubs, unexpected', () => {
const wrapper = mount(TheComponent, { store, localVue, propsData: {…} });
// The component has stubs too!
} Why? 😕 |
The bug has been reported—#1050 Follow that thread for updates |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stub components during $createElement call. This way we will always stub components, including dynamically added components
Extend components during $createElement call. This avoids the previous recursive lookup, and ensures we only extend components that are rendered
Use tag in stub name
Fixes Warning messages thrown about child components created with
vue.extend
even when parent component is mounted withshallowmount
#973Fixes Unknown custom element: <router-link> when using
mount()
#994Fixes Using a <component> tag does not stub the component when using shallowMount #995
Breaking change: this will change the output of some stubs