Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: create stubs in createElement #1038

Merged
merged 17 commits into from
Nov 25, 2018

Conversation

eddyerburgh
Copy link
Member

Breaking change: this will change the output of some stubs

@eddyerburgh eddyerburgh merged commit e1fd705 into vuejs:dev Nov 25, 2018
@eddyerburgh eddyerburgh deleted the create-stubs-in-render branch November 25, 2018 08:20
@afv
Copy link

afv commented Dec 4, 2018

Hello!

After this change I'm getting stubbed components on mounted (not shallow) components if the component was previously shallow mounted (on another test).

it('renders the component without stubs', () => {
  const wrapper = mount(TheComponent, { store, localVue, propsData: {} });
  // The component has no stubs, as expected
}

it('renders the component again without stubs', () => {
  const wrapper = mount(TheComponent, { store, localVue, propsData: {} });
  // The component has no stubs, as expected
}

But:

it('renders the component with stubs', () => {
  const wrapper = shallowMount(TheComponent, { store, localVue, propsData: {} });
  // The component has stubs, as expected
}

it('renders the component with stubs, unexpected', () => {
  const wrapper = mount(TheComponent, { store, localVue, propsData: {} });
  // The component has stubs too!
}

Why? 😕

@eddyerburgh
Copy link
Member Author

The bug has been reported—#1050

Follow that thread for updates

@eddyerburgh eddyerburgh changed the title Create stubs in render feat: create stubs in createElement Dec 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants