Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add child-Prop in stub of ChildComponent (when using snapshot) #708

Closed
trollepierre opened this issue Jun 12, 2018 · 3 comments · Fixed by #834
Closed

Add child-Prop in stub of ChildComponent (when using snapshot) #708

trollepierre opened this issue Jun 12, 2018 · 3 comments · Fixed by #834

Comments

@trollepierre
Copy link
Contributor

What problem does this feature solve?

I would like to see in my snapshot that I call my childcomponent with correct prop.

 <childcomponent-stub child-Prop="'some propsData that needs to be tested'"/>

Here is a failing test with my expected snapshot:

https://codesandbox.io/s/ql77047m9q

What does the proposed API look like?

nothing to add here

@trollepierre
Copy link
Contributor Author

Hey @eddyerburgh , will this feature be ready for the next release? Thx

@eddyerburgh
Copy link
Member

eddyerburgh commented Jul 4, 2018

No sorry, the priority for me is bug fixes, and I'm busy with writing my book. I'm happy to review a PR for this feature, but I don't have the time to implement myself at the moment.

@sobolevn
Copy link

sobolevn commented Aug 1, 2018

As I get it, we now have props that are raw objects when using shallow mounts?
And good-old-regular props when using mount()?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants