Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix transitions on v-show cancelled on next frame (fix #7390) #7391

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Fix transitions on v-show cancelled on next frame (fix #7390) #7391

merged 2 commits into from
Jan 5, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Jan 5, 2018 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Guillaume Chau added 2 commits January 5, 2018 18:03
test(transition): Transitions cancelled on next frame
0959b17 
Add two tests (enter and leave) that cancels the transitions on v-show
fix(transition): Don't add 'to' class if transition is cancelled
3c7dbdb 
When a transition is cancelled before the next frame, the `v-enter-to` or `v-leave-to` class was
still added to the element.

fix vuejs#7390
@Akryum Akryum requested a review from yyx990803 January 5, 2018 17:11
@Akryum Akryum self-assigned this Jan 5, 2018
@Akryum Akryum added the 2.x label Jan 5, 2018
@yyx990803 yyx990803 merged commit 5191f13 into vuejs:dev Jan 5, 2018
@Akryum Akryum deleted the 7390-transition-prevent-to-class-if-cancelled branch January 6, 2018 15:15
lovelope pushed a commit to lovelope/vue that referenced this pull request Feb 1, 2018
@lovelope
fix(transition): should not add transition class when cancelled (vuej…
667d06a 
…s#7391)

fix vuejs#7390
@yyx990803 yyx990803 mentioned this pull request Mar 9, 2018
Closed
This was referenced Mar 14, 2018
Closed
Merged
Merged
Open
Open
Open
Open
Closed
Merged
Closed
Closed
Merged
Merged
Merged
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
fix(transition): should not add transition class when cancelled (vuej…
c7efd9d 
…s#7391)

fix vuejs#7390
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
@aJean
fix(transition): should not add transition class when cancelled (vuej…
4418420 
…s#7391)

fix vuejs#7390
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees

@Akryum Akryum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akryum @yyx990803