Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: remove node env flag #1749

Merged
merged 2 commits into from
May 14, 2020
Merged

refactor: remove node env flag #1749

merged 2 commits into from
May 14, 2020

Conversation

cuebit
Copy link
Member

@cuebit cuebit commented May 13, 2020

Replaces the orphaned process.env.NODE_ENV with the new global __DEV__.

@cuebit cuebit added the 4.x label May 13, 2020
@cuebit cuebit requested a review from kiaking May 13, 2020 23:44
kiaking
kiaking approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@kiaking kiaking added the bug Something isn't working label May 14, 2020
@kiaking kiaking merged commit 0fea8c4 into 4.0 May 14, 2020
@kiaking kiaking deleted the replace-node-env branch May 14, 2020 02:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees

@cuebit cuebit

Labels
4.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuebit @kiaking