Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(MdLayout): remove breakpoint margins #1457

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

Samuell1
Copy link
Member

Fix #1307

@marcosmoura marcosmoura merged commit c568fe3 into dev Jan 29, 2018
@marcosmoura marcosmoura deleted the fix/MdLayout/remove-margins branch January 29, 2018 20:26
marcosmoura pushed a commit that referenced this pull request Jan 29, 2018
* 'dev' of github.com:vuematerial/vue-material:
  fix(MdLayout): remove breakpoint margins (#1457)
@zevdg
Copy link
Contributor

zevdg commented Jan 30, 2018

Shouldn't

@media (max-width: #{$md-breakpoint-large - 17px}) {
and
@media (min-width: #{$md-breakpoint-large - 16px}) {
also have been fixed in this PR? They appear to have the same problem.

@marcosmoura
Copy link
Member

@zevdg Large breakpoints should have this 16px margin, as stated in the guidelines:

Desktop breakpoints are 16dp below the listed values to accommodate variations in browser.

@zevdg
Copy link
Contributor

zevdg commented Jan 30, 2018

Aaaahh, I see it now. Thanks for the clarification.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants