fix(MdField): fix textarea and inline issues #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uematerial/vue-material into fix/MdField/fix-textarea-and-inline-issues
|
@marcosmoura can you please review and merge asap, so i can do some this related fix in other field components (chips, file autocomplete and datepicker) |
|
Looks like label for textarea with grow is still misaligned
|
|
Sorry, i didn't get you.. |
|
@shafimsp space under label is bigger then on normal inputs |
|
I will look on it. Thank you |
|
@Samuell1 I have looked, i think its correct. Please see below images.
|
|
I overlayped normal input with textarea autogrow input and label is misaligned. Screenshot is from Firefox maybe thats the issue? |
|
I was checked on chome. Will look on Firefox |
|
@Samuell1 can you please check it? Thank you |
|
Now it looks fine.
|
marcosmoura
approved these changes
Apr 2, 2018
marcosmoura
added a commit
that referenced
this pull request
May 13, 2018
This reverts commit dbeb7e9.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues caused by #1600
Fix issues mentioned in #1601 comment
Fix prefix and suffix with icon and other variants issues