feat(core)!: remove headers field from page data #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11266238703Details
💛 - Coveralls |
|
Then the |
|
Could headers be server-side rendered after the change? |
|
I think the header information might still be required on the page object, but we should no longer pass it to client data by default. |
|
I see. What about SSR? Seems that helper pkg is using DOM api to get headers. |
|
A toc is not needed for ssr I think. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces page data size by removing headers info from page data, downstream themes can infer headers via dom structure with
@vuepress/helperand they can manually write it to page data if necessary.