Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(client): improve client data types #1626

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(client): improve client data types #1626

merged 1 commit into from
Jan 21, 2025

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jan 17, 2025

Developers should prefer to use useClientData directly if they need multiple composables at one place:

- const frontmatter = usePageFrontmatter()
- const pageData = usePageData()
+ const { fontmatter, pageData } = useClientData()

This PR ensure frontmatter and pageData can be easily typed.

@Mister-Hope Mister-Hope requested a review from meteorlxy January 17, 2025 07:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12824782477

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.722%

Totals Coverage Status
Change from base Build 12271244431: 0.0%
Covered Lines: 648
Relevant Lines: 906

💛 - Coveralls

@meteorlxy meteorlxy merged commit 8bd5438 into main Jan 21, 2025
30 checks passed
@meteorlxy meteorlxy deleted the client-data branch January 21, 2025 12:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants