Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Enhancement] Bump esbuild to v0.25.x #1634

Closed
Amndeep7 opened this issue Feb 24, 2025 · 4 comments
Closed

[Enhancement] Bump esbuild to v0.25.x #1634

Amndeep7 opened this issue Feb 24, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@Amndeep7
Copy link

Description

Esbuild <= v0.25.0 is vulnerable.

See: GHSA-67mh-4wv8-2f99 and https://github.com/evanw/esbuild/releases/tag/v0.25.0

The @vuepress/cli uses v0.24.2.

Reproduction

n/a

Used Package Manager

npm

System Info

n/a
@Amndeep7
Copy link
Author

When vite v6.2.0 is released, dependent libraries and applications in this repo will also need to be updated so as to fully move over to esbuild 0.25.x.

https://github.com/vitejs/vite/blob/e01573a5757420041530d47f707c720da5fe2231/packages/vite/CHANGELOG.md#620-beta0-2025-02-21

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 25, 2025

Thank for reporting, but the vulnerability was a false positive to us. Make sure you fully understand such things before opening next time :)

It's about https://esbuild.github.io/api/#serve, while we are not using it. Esbuild is only used to transpire ts config file to js so that node can load it.

Also, vite and webpack's esbuild-load are also not using this api, so you can see that vite bump this as bug fixes for certain CSS, rather than releasing a security patch immediately.

We will keep the version with Vite to avoid duplicate deps.

@Mister-Hope Mister-Hope changed the title [Bug report] Bump esbuild to v0.25.x [Enhancement] Bump esbuild to v0.25.x Feb 25, 2025
@Mister-Hope Mister-Hope added the enhancement New feature or request label Feb 25, 2025
@Amndeep7
Copy link
Author

Yeah I figured that yall were not vulnerable to it, but the CVE scanners pick it up regardless, so wanted to just resolve the problem haha. Understood re: waiting for the vite release before updating.

@meteorlxy
Copy link
Member

4161600

Thanks for reporting!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants