Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(VNumberInput): attributes fall through to root #19959

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Jun 6, 2024

fix #19953

Description

I fixed it because attr was not used.

Markup:

  <v-app>
    <v-container>
      <v-text-field
        aria-autocomplete="none"
        autocomplete="off"
        label="Label"
        aru
      ></v-text-field>
      <v-number-input
        :hideInput="false"
        :inset="false"
        :reverse="false"
        aria-autocomplete="none"
        autocomplete="off"
        controlVariant="default"
        label=""
      ></v-number-input>
    </v-container>
  </v-app>

Copy link
Member

@yuwu9145 yuwu9145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove inheritAttrs: false to let attributes fall through

@babu-ch
Copy link
Contributor Author

babu-ch commented Jun 7, 2024

@yuwu9145
Thank you for your help.
I fixed it like that

@babu-ch babu-ch requested a review from yuwu9145 June 7, 2024 06:11
@yuwu9145 yuwu9145 added T: bug Functionality that does not work as intended/expected C: VNumberInput labels Jun 7, 2024
@yuwu9145 yuwu9145 added this to the v3.6.x milestone Jun 7, 2024
@yuwu9145 yuwu9145 changed the title fix(VNumberInput): allow setting attribute fix(VNumberInput): attributes fall through to root Jun 7, 2024
@yuwu9145 yuwu9145 merged commit df6440d into vuetifyjs:master Jun 7, 2024
10 checks passed
@babu-ch babu-ch deleted the fix/19953-v-number-input-attr branch July 14, 2024 04:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C: VNumberInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.8] VNumberInput does not retain aria-autocomplete attribute
2 participants