Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(VListItem): remove aria-selected on VListItem #20708

Closed
wants to merge 1 commit into from

Conversation

AllanOcelot
Copy link

Description

I have removed the attribute 'aria-selected' from '/components/VList/VListItem.tsx' to resolve #20666 .
It is marked as good first issue, and I wanted to get familiar with the vuetify dev environment, to contribute in future.

Playground file to replicate

<template>
  <v-app>
    <v-container>
      <v-list lines="one">
        <v-list-item
          v-for="n in 3"
          :key="n"
          :title="'Item ' + n"
          subtitle="Lorem ipsum dolor sit amet consectetur adipisicing elit"
        ></v-list-item>
      </v-list>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    setup () {
      return {
        //
      }
    },
  }
</script>

@AllanOcelot AllanOcelot changed the title FIX - Remove aria-selected on VListItem (#20666) fix ( VListItem): remove aria-selected on VListItem ) (#20666) Nov 16, 2024
@AllanOcelot AllanOcelot changed the title fix ( VListItem): remove aria-selected on VListItem ) (#20666) fix (VListItem): remove aria-selected on VListItem Nov 16, 2024
@AllanOcelot
Copy link
Author

I was not aware there was a naming convention for PR's - apologies !

@AllanOcelot AllanOcelot changed the title fix (VListItem): remove aria-selected on VListItem fix(VListItem): remove aria-selected on VListItem Nov 16, 2024
@KaelWD KaelWD closed this in 72df0b4 Nov 20, 2024
@KaelWD
Copy link
Member

KaelWD commented Nov 20, 2024

Thanks for your contribution, this is still needed for selectable items though.

KaelWD added a commit to J-Sek/vuetify that referenced this pull request Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.7.3] V-List-Items should not have property "aria-selected"
2 participants