Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

VkSwapchainCreateInfoKHR Valid Usage of the Vulkan specification is partially ignored. #1165

Closed
hikitrbogithub opened this issue Feb 6, 2019 · 1 comment

Comments

@hikitrbogithub
Copy link
Contributor

hikitrbogithub commented Feb 6, 2019

The Vulkan specification, mentions the following:

If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1

If imageSharingMode is VK_SHARING_MODE_CONCURRENT, each element of pQueueFamilyIndices must be unique and must be less than pQueueFamilyPropertyCount returned by either vkGetPhysicalDeviceQueueFamilyProperties or vkGetPhysicalDeviceQueueFamilyProperties2 for the physicalDevice that was used to create device

https://docs.rs/vulkano/0.11.1/src/vulkano/swapchain/swapchain.rs.html#366-408
Allows for misuse, for example:

  • Calling vulkano::swapchain::Swapchain::new with vulkano::sync::SharingMode::Concurrent(std::vec::Vec::new()) as an argument, would break the former requirement.

  • Calling vulkano::swapchain::Swapchain::new with vulkano::sync::SharingMode::Concurrent(vec![1, 1]) as an argument, would break the latter requirement.

@marc0246
Copy link
Contributor

marc0246 commented Jul 7, 2023

This has been fixed in #1832.

@marc0246 marc0246 closed this as completed Jul 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants