Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DeviceLocalBuffer API doesn't expose sharing mode #2126

Closed
john01dav opened this issue Jan 7, 2023 · 1 comment · Fixed by #2127
Closed

DeviceLocalBuffer API doesn't expose sharing mode #2126

john01dav opened this issue Jan 7, 2023 · 1 comment · Fixed by #2127

Comments

@john01dav
Copy link

DeviceLocalBuffer's constructors don't expose SharingMode, so I didn't even know that this existed at first. It came to my attention when validation layers detected that it was not set correctly. It's set to Exclusive by default, but I need it to be set to Concurrent since I am uploading data to my buffers in a background thread on a background queue, then using them on the main thread in the main queue.

Looking at the source code, this seems like a fairly easy fix, but adding a parameter is an API change so it warrants discussion before making a PR.
@Rua
Copy link
Contributor

Rua commented Jan 7, 2023

I'm guessing that this will be fixed by @marc0246's upcoming buffer refactoring.

@marc0246 marc0246 mentioned this issue Jan 11, 2023
Merged
@Rua Rua closed this as completed in #2127 Jan 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify all buffer types marc0246/vulkano
2 participants
@Rua @john01dav