Vulkano d

[gurchetansingh]

I'm trying to build Vulkano as a dependency in ToT crosvm, but it started failing.

Try this:

git clone https://chromium.googlesource.com/crosvm/crosvm

Add the following patch, and make sure it points to your internal Vulkano checkout:

deleted file mode 100644
index d1397911b..000000000
--- a/rust-toolchain
+++ /dev/null
@@ -1,3 +0,0 @@
-[toolchain]
-channel = "1.68.2"
-components = [ "rustfmt", "clippy", "llvm-tools-preview" ]
diff --git a/rutabaga_gfx/Cargo.toml b/rutabaga_gfx/Cargo.toml
index 50a0fe694..332c3b126 100644
--- a/rutabaga_gfx/Cargo.toml
+++ b/rutabaga_gfx/Cargo.toml
@@ -18,6 +18,7 @@ vulkano = []
 x = []
 
 [dependencies]
+regex = "1"
 cfg-if = "1.0.0"
 data_model = { path = "../common/data_model", version = "0.1.1-alpha.1"}
 libc = "0.2.116"
@@ -25,6 +26,7 @@ remain = "0.2"
 thiserror = "1.0.23"
 zerocopy = "0.6"
 log = "0.4"
+vulkano = { path = "../../vulkano/vulkano" }
 
 [target.'cfg(unix)'.dependencies]
 nix = "0.26.1"
@@ -32,9 +34,6 @@ nix = "0.26.1"
 [target.'cfg(windows)'.dependencies]
 winapi = "0.3"
 
-# To build latest Vulkano, change version to git = "https:/github.com/vulkano-rs/vulkano.git"
-# vulkano = { version = "0.31.0", optional = true }
-
 [build-dependencies]
 pkg-config = "0.3"
 anyhow = "1.0.57"

Try cargo build in the rutabaga_gfx directory. It should fail with something like:

error[E0599]: no method named `len` found for struct `regex::Match` in the current scope
   --> /usr/local/google/home/gurchetansingh/gfx/vulkano/vulkano/autogen/extensions.rs:920:34
    |
920 |             depends = &depends[m.len()..];
    |                                  ^^^ method not found in `Match<'_>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `vulkano` (build script) due to previous error

Interestingly, it does not fail with vulkano version v.0.33.

Any ideas @Rua?