Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

missing defer on f.close #78

Merged
merged 1 commit into from
Nov 11, 2020
Merged

missing defer on f.close #78

merged 1 commit into from
Nov 11, 2020

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Nov 11, 2020

Description

Missing defer on f.close which was causing further checks to fail.

Related Issues

Fixes #76

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from Oogy November 11, 2020 00:24
@ddymko ddymko mentioned this pull request Nov 11, 2020
Closed
@mamclaughlin mamclaughlin self-requested a review November 11, 2020 14:23
@ddymko ddymko merged commit 6a0c785 into vultr:master Nov 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mamclaughlin mamclaughlin mamclaughlin approved these changes

@Oogy Oogy Awaiting requested review from Oogy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Debug: Build 'vultr' errored ... vultr_vultr.pem: file already closed
2 participants
@ddymko @mamclaughlin