-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CleanRL can't be used by importing? #197
Comments
Hi, @cool-RR thanks for raising this issue. You are absolutely correct that CleanRL cannot be imported. Does https://github.com/vwxyzjn/cleanrl/blob/b0d00df8b926617651638923e622b51c0b477305/README.md better than clarify this?
CleanRL doesn't really support this, unfortunately. For the That said though, prototyping with SB3 can be challenging. As an example, it takes considerably more code to implement invalid action masking in SB3 (see PR) whereas in CleanRL it's just about 30 lines of code (see "invalid action masking" in this post). Unfortunately, there is no perfect solution for doing prototypes. CleanRL can help you to understand the core of implementing invalid action masking to work with pettingzoo's chess, empowering you to build prototypes faster. Once you understand the core of the implementation, it would help you more seamlessly contribute the same feature to SB3 for wider adoption. |
Thanks for the quick PR, I commented there.
I understand, thanks. |
Hi @vwxyzjn !
Jordan recommended that I use CleanRL when working with Petting Zoo, and it took me a bit to figure out something. Let me know whether I understand correctly. CleanRL isn't meant to be imported and used directly, like SB3. It's supposed to have reference implementations of algorithms which developers could copy off to their own program and tweak as necessary to serve their needs.
Is this correct? If so:
import PPO
and have it work.The text was updated successfully, but these errors were encountered: