Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

default functions don't respect nonreentrancy keys #2455

Closed
Tracked by #2471
charles-cooper opened this issue Sep 10, 2021 · 1 comment
Closed
Tracked by #2471

default functions don't respect nonreentrancy keys #2455

charles-cooper opened this issue Sep 10, 2021 · 1 comment
Labels
bug Bug that shouldn't change language semantics when fixed.

Comments

@charles-cooper
Copy link
Member

Version Information

  • vyper Version (output of vyper --version): v0.2.16

nonreentrant keys are allowed on default functions, e.g.

@external
@payable
@nonreentrant("default")
def __default__():
    pass

but it doesn't do anything, here's the output:

      [seq,
        [if, [lt, calldatasize, 4], [goto, fallback]],
        [mstore, 28, [calldataload, 0]],
        [with, _func_sig, [mload, 0], seq],
        [seq_unchecked,
          [label, fallback],
          [seq,
            pass,
            # Line 5
            pass,
            pass,
            # Line 4
            stop]]],

@charles-cooper charles-cooper added the bug Bug that shouldn't change language semantics when fixed. label Sep 10, 2021
@charles-cooper
Copy link
Member Author

fixed in #2447

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bug that shouldn't change language semantics when fixed.
Projects
None yet
Development

No branches or pull requests

1 participant