Skip to content

incorrect ordering of default arguments passed to internal calls

High
charles-cooper published GHSA-ph9x-4vc9-m39g May 11, 2023

Package

pip vyper (pip)

Affected versions

<=0.3.7

Patched versions

0.3.8

Description

Impact

Internal calls to internal functions with more than 1 default argument are compiled incorrectly. Depending on the number of arguments
provided in the call, the defaults are added not right-to-left, but left-to-right. If the types are incompatible,
typechecking is bypassed. In the bar() function in the following code, self.foo(13) is compiled to
self.foo(13,12) instead of self.foo(13,1337).

@internal
def foo(a:uint256 = 12, b:uint256 = 1337):
    pass

@internal
def bar():
    self.foo(13)

note that at the time of publication, the ability to pass kwargs to internal functions is an undocumented feature that does not seem to be widely used.

Patches

patched in c3e68c3

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

References

Are there any links users can visit to find out more?

Severity

High

CVE ID

CVE-2023-32059

Weaknesses

No CWEs

Credits