Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Continued development and new features, #2

Open
silveroxides opened this issue Jan 6, 2024 · 5 comments
Open

Continued development and new features, #2

silveroxides opened this issue Jan 6, 2024 · 5 comments

Comments

@silveroxides
Copy link

Hello. Thanks for updating the repo to latest version.
I was thinking about one thing that I have felt missing from the extension. Perhaps two even. First one is the option to save/convert embedding to safetensors since I have noticed a lot of reluctance from less experienced users when it comes to using anything named pickle. So rather than having to set up separate venv and initiate conversion it would be neat as an option for when you save the embedding. Can't really do long lectures about everything surrounding embedding, pickle, security every time I share an embedding. (I use this in parallel to embeddings merge extension to manually construct and restructure vectors within embeddings regularly)

The other thing I thought about would be something like a csv that saves previous operations so one can look back easily and perhaps the option to add own Eval presets in the UI.

Tell me if these sound interesting and I might take a crack at it once I have som spare time

@w-e-w
Copy link
Owner

w-e-w commented Jan 6, 2024

I have noticed a lot of reluctance from less experienced users when it comes to using anything named pickle

which indeed they should for good reason

First one is the option to save/convert embedding to safetensors

sure security is goodm


The other thing I thought about would be something like a csv that saves previous operations so one can look back easily and perhaps the option to add own Eval presets in the UI.

I don't use this extension myself I was merely asked to restore this repository
naturally I don't know how people usually use the extension
you're saying is basically something that to save configurations so that it can be quickly loaded again
that indeed sounds like something that is generally useful

I have said in readme that I'm don't intending to maintain or develop this extension
if you want to make it the thing go ahead
I have no issues with accepting PR's
if you are serious about maintaining this extension then I could add you as a collaborator (naturally after you have proven yourself as trustworily for obvious reasons)

@benjamin-bertram
Copy link

I have commited some minor changes so the embeddings get saved as safetensors. wdt?

@w-e-w
Copy link
Owner

w-e-w commented Feb 7, 2024

I have commited some minor changes so the embeddings get saved as safetensors. wdt?

if you can set over a PR that would be nice

@benjamin-bertram
Copy link

https://github.com/benjamin-bertram/embedding-inspector/blob/main/scripts/embedding_inspector.py
Should be here. I tried to get SDXL to work but, It took too long to understand the architecture where clip for sdxl is located

@hyppyhyppo
Copy link

An SDXL support would be great indeed. I used it a lot for merging embeddings together or with additional tokens.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants