Dialog for changing candidate review completion target date has several critical problems

[mcking65]

The dialog that opens with a button for changing the target date in the candidate review column of the test plan status summary table on the data management page has the following problems:

1. It allows invalid dates: Earliest allowed date should be 180 days after the day that candidate review started. Note that this may still be in the past and might also be earlier than the R&D complete date of the version currently in candidate review.
2. When the date is saved, one day is subtracted. Example, set the date to Sep 30, 2023 and then save. Re-open the dialog , and the date in the field will be Sep 29, 2023.
3. Accessibility issue: The date input should receive focus when the dialog opens.
4. Accessibility issue: The label of the input is not associated with the input.
5. Accessibility issue: The dialog is not labeled. It has aria-labelledby, but the idref is invalid. It should reference the heading.
6. Accessibility issue: Like several of the other dialogs, the tab sequence is broken. Tabbing from the save button should move focus to the date input. Back tabbing from the date input should move focus to the save button.

[howard-e]

6. Accessibility issue: Like several of the other dialogs, the tab sequence is broken. Tabbing from the save button should move focus to the date input. Back tabbing from the date input should move focus to the save button.

@mcking65 I think this is the same as what was reported in #757. The team found that this is a side-effect of the underlying bootstrap component and are tracking that work to submit against that.

The other items will be assigned

[mcking65]

@howard-e wrote:

6. Accessibility issue: Like several of the other dialogs, the tab sequence is broken. Tabbing from the save button should move focus to the date input. Back tabbing from the date input should move focus to the save button.

@mcking65 I think this is the same as what was reported in #757. The team found that this is a side-effect of the underlying bootstrap component and are tracking that work to submit against that.

The other items will be assigned

Thanks. Yes, it is the same tabbing issue.

Please create a separate issue in this repo to track/link to the work on the bootstrap component.

[howard-e]

Please create a separate issue in this repo to track/link to the work on the bootstrap component.

#805 covers that

[mcking65]

@howard-e, @ccanash

In staging, I can still reproduce 5 of the 6 bugs I reported in this issue. Plus, there are two other related bugs that I either didn't previously notice or are new. I don't want to create a new issue; I wonder if this should be moved back to in-progress?

Here are the details of my current observations.

1. It allows invalid dates: Earliest allowed date should be 180 days after the day that candidate review started. Note that this may still be in the past and might also be earlier than the R&D complete date of the version currently in candidate review.

I tested using the candidate review column for "Action Menu Button Example Using aria-activedescendant". The first version of this plan to reach candidate review is V22.03.17. It started review July 25, 2023. So, it should not allow a target date sooner than Jan 21, 2024. I can still enter any date I please, and it will be saved.

2. When the date is saved, one day is subtracted. Example, set the date to Sep 30, 2023 and then save. Re-open the dialog , and the date in the field will be Sep 29, 2023.

This is still happening. It seemed that the first time I tried, it may not have happened, but subsequent saves kept subtracting a day.

3. Accessibility issue: The date input should receive focus when the dialog opens.

The focus is still getting set on the heading.

4. Accessibility issue: The label of the input is not associated with the input.

The accessible name should be the element containing the string "Target Date". The browser is still falling back to the placeholder value for the accessible name.

5. Accessibility issue: The dialog is not labeled. It has aria-labelledby, but the idref is invalid. It should reference the heading.

This is still the same. The aria-labelledby value on the div with role dialog is not referring to the heading element inside the dialog.

6. Accessibility issue: Like several of the other dialogs, the tab sequence is broken. Tabbing from the save button should move focus to the date input. Back tabbing from the date input should move focus to the save button.

Hurray!! This is fixed!

Two other bugs are:

After saving a new target date value, the link for the test plan version is getting corrupted. The text of the link goes away. In particular, this element inside of the link, <b>V22.03.17</b>, is empty after saving a new target date value.

Secondly, the dialog does not close when escape is pressed.

[ccanash]

#806 fixed Accessibility issue: Like several of the other dialogs, the tab sequence is broken. Tabbing from the save button should move focus to the date input. Back tabbing from the date input should move focus to the save button.

[ccanash]

Hi @mcking65 , we released this to production on dec 5th. Is it ok with you if we close it?