Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Non-ASCII characters are not displayed correctly #484

Closed
janek515 opened this issue Dec 3, 2022 · 2 comments · Fixed by #501
Closed

Non-ASCII characters are not displayed correctly #484

janek515 opened this issue Dec 3, 2022 · 2 comments · Fixed by #501
Assignees
@Unthrottled
Labels
type: bug Something isn't working

Comments

@janek515
Copy link

janek515 commented Dec 3, 2022

Describe the bug
Non-ASCII characters are not displayed correctly

To Reproduce
Steps to reproduce the behavior:

  1. Open IDE
  2. See Waifu of the day dialog
  3. Non-ascii characters in the description look like a mess

Expected behaviour

Non-ASCII characters displayed correctly

Screenshots

image

Platform:

  • OS: Windows 11
  • IDE WebStorm
  • IDE Version 2022.3
  • Version WMP 2.4.0

Additional context

My PC language is set to Polish, while my IDE is in English. Maybe this messes with encoding in some way
@janek515 janek515 added the type: bug Something isn't working label Dec 3, 2022
@Unthrottled
Copy link
Member

I've seen similar issues related to this on the Windows platform in other places.

I might have some time later to take a look into it, thanks for taking the time to report the issue!

@Unthrottled Unthrottled self-assigned this Jan 24, 2023
@Unthrottled Unthrottled mentioned this issue Jan 24, 2023
Merged
@Unthrottled
Copy link
Member

Figured out the issue.

Step 1: Decode the description assets correctly (in utf-8).
Step 2: ???
Step 3: Profit! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Unthrottled Unthrottled

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: Rendering 漢字 better waifu-motivator/waifu-motivator-plugin
2 participants
@Unthrottled @janek515