-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[BUG] Countdown clock text is inaccurate #79
Comments
I wonder if this is caused by lag in pam invoking conv.send()? However I don't recall this on earlier versions of pam-authramp |
I've noticed this before. I think it is a latency issue. One possible fix could be to only send a message every two seconds to get a more accurate remaining time. what do you think? |
hmm i'll test it with pamtester. If there is the same issue, then it must lie with the authramp implementation. |
thanks, and FYI this is on any secureblue silverblue image with tag br-staging-40 |
This is OS or display manager latency. When using pamtester the 30s are actually 30s. Tested this with a stoppwatch. In theory displaying the message every 2nd second should help with the accuracy. |
@34N0 That makes sense. Making this configurable could be an easy fix. Or also, what about just displaying the timestamp when the user will be able to try again? Something like |
That works too :) Thanks |
lazy fix for now. but i am open for something simpler like the timestamp idea! |
I wonder though, do you think this is an option on SDDM or LightDM? or would it still not work? |
I think it wouldn't change the experience a lot on LightDM since it allways displays the latest countdown message but doesn't count lower automatically. SDDM does not display any PAM messages. It does not support it. |
I see, makes sense |
the countdown is much more accurate now! there's still a little bit of drift, but it's roughly correct. Making this configurable or the timestamp I mentioned would be good nice-to-have features to make the experience even better, but overall it's working well on GNOME now! 🥳 |
From now on, when looping is disabled in config a timestamp will be displayed. |
After triggering the lockout mechanism and the 30 second countdown, each second on the countdown takes about 1.5-2 seconds, clearing once it hits around 13 seconds remaining.
I used a stopwatch to time it, and the locking mechanism is accurate, it locks for 30 seconds. Just the countdown text itself is inaccurate.
The text was updated successfully, but these errors were encountered: