Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Contradictory statements about CODATA version #429

Open
jaemolihm opened this issue Jul 29, 2022 · 0 comments
Open

Contradictory statements about CODATA version #429

jaemolihm opened this issue Jul 29, 2022 · 0 comments
Assignees
Milestone

Comments

@jaemolihm
Copy link
Contributor

There are two versions of fundamental constants implemented: CODATA 2010 and 2006.

The header of constants.F90 says that the default is CODATA 2010,

!! Values of the fundamental constants are taken from
!! http://physics.nist.gov/cuu/Constants/index.html
!! By default CODATA2010 is used (CODATA2006 can be selected
!! using an appropriate compile-time flag (see INSTALL guide)

while README.install says CODATA 2006 is the default.

wannier90/README.install

Lines 223 to 229 in bf0642b

* CODATA2006
Use physical constants from 2006 version of CODATA tables
(http://physics.nist.gov/cuu/Constants/index.html)
(Note that this is the default choice if nothing is specified)
* CODATA2010
Use physical constants from 2010 version of CODATA tables
(http://physics.nist.gov/cuu/Constants/index.html)

From the code, it seems that 2006 is the default.

!~ Pick up default value; unfortunately, it doesn't work with indentation...
#ifndef CODATA2006
#ifndef CODATA2010
#define CODATA2006
#endif
#endif

@jryates jryates added the bug label Feb 12, 2024
@jryates jryates added this to the v4.0 milestone Feb 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants