Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove enable-serde feature on compiler types #5241

Open
xdoardo opened this issue Nov 11, 2024 — with Linear · 0 comments
Open

Remove enable-serde feature on compiler types #5241

xdoardo opened this issue Nov 11, 2024 — with Linear · 0 comments
Assignees
Labels
cleanup Lets clean up the code! 📦 lib-api About wasmer 📦 lib-compiler About wasmer-compiler

Comments

Copy link
Contributor

xdoardo commented Nov 11, 2024

Some of the "compiler types" we use (e.g. Relocation, RelocationKind,…) are marked to implement serde's traits depending on the enable-serde feature being enabled. It seems that this feature is not needed anymore. An example of these types is the following:

#[cfg_attr(feature = "artifact-size", derive(loupe::MemoryUsage))]
// #[cfg_attr(feature = "enable-serde", derive(Serialize, Deserialize))] <- remove me
#[derive(RkyvSerialize, RkyvDeserialize, Archive, Copy, Clone, Debug, PartialEq, Eq)]
#[rkyv(derive(Debug), compare(PartialEq))]
#[repr(u8)]
pub enum RelocationKind {
  ...
}
@xdoardo xdoardo added cleanup Lets clean up the code! 📦 lib-api About wasmer 📦 lib-compiler About wasmer-compiler labels Nov 11, 2024 — with Linear
@xdoardo xdoardo self-assigned this Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cleanup Lets clean up the code! 📦 lib-api About wasmer 📦 lib-compiler About wasmer-compiler
Projects
None yet
Development

No branches or pull requests

1 participant