You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We tried to get the c-api backends to run/build on iOS/Android and found an issue on 32bit build-targets.
The following line fails to build on 32bit targets due to a overflow error (default integer type on 32bit targets is i32):
ifself.inner.map.len() >= 1 << 32{
Casting both sides to u64 solves the issue, and probably is also what is expected here. A problem would only arise for targets where usize uses more than 64bit, which as far as I know, does not exist yet.
We patched it on our fork, and I'm glad to make a pull request if you approve of this fix. Otherwise we are open for discussion: fffca20
The text was updated successfully, but these errors were encountered:
We tried to get the c-api backends to run/build on iOS/Android and found an issue on 32bit build-targets.
The following line fails to build on 32bit targets due to a overflow error (default integer type on 32bit targets is i32):
Casting both sides to u64 solves the issue, and probably is also what is expected here. A problem would only arise for targets where
usize
uses more than 64bit, which as far as I know, does not exist yet.We patched it on our fork, and I'm glad to make a pull request if you approve of this fix. Otherwise we are open for discussion:
fffca20
The text was updated successfully, but these errors were encountered: