Unable to Add Orbstack Machine to Connections

[oliv10]

Describe the bug
I use another piece of software called Orbstack. One really cool thing it allows you to do is create what is basically a VM that runs on your own machine. And by default, they are accessible by SSH to your machine only. However, after reading the release notes for 0.5.1, I assume the issue is that the REGEX for the connection only allows for one '@' symbol. Just like how it wouldn't allow for dots or underscores which was an issue for me as well.

To Reproduce
Steps to reproduce the behavior:

1. Install Orbstack
2. Configure Linux Machine
3. Configure connection to Orbstack machine on Waveterm

Expected behavior
Creates an SSH connects to the specified host.

Screenshots

Desktop (please complete the following information):

• OS: MacOS
• Version 0.5.1

Additional context
Need to have Orbstack installed and configured.

[oliv10]

# AUTO-GENERATED BY ORBSTACK. DO NOT EDIT.
# To make changes, add or override hosts at the top of ~/.ssh/config

Host orb
  Hostname 127.0.0.1
  Port 32222
  # SSH user syntax:
  #   <container>@orb to connect to <container> as the default user (matching your macOS user)
  #   <user>@<container>@orb to connect to <container> as <user>
  # Examples:
  #   ubuntu@orb: container "ubuntu", user matching your macOS user
  #   root@fedora@orb: container "fedora", user "root"
  User default
  # replace or symlink ~/.orbstack/ssh/id_ed25519 file to change the key
  IdentityFile ~/.orbstack/ssh/id_ed25519
  # only use this key
  IdentitiesOnly yes
  ProxyCommand '/Applications/OrbStack.app/Contents/Frameworks/OrbStack Helper.app/Contents/MacOS/OrbStack Helper' ssh-proxy-fdpass /Users/USERNAME
  ProxyUseFdpass yes

For more context, Orbstack auto generates its own config file and its then incuded this in the ~/.ssh/config so it can function.

[sawka]

Thanks for submitting! Hadn't heard of Orb before, but it looks cool. I don't see any big reason why we couldn't loosen up the syntax to allow for a username with an "@" in it. If it works with ssh (which your screenshot clearly showed it does), it should be possible to support. Will try to get this in the v0.5.2 release.

Will mark as an enhancement (as opposed to a bug) since I feel like usernames with at-signs aren't standard :)

[oliv10]

Awesome, glad to see that! One of my co-workers found this about a week ago and it works really nicely with our labs workflow so I will probably have some more ideas or bugs to throw at you in time.

[oneirocosm]

close as this should be fixed by #129